[
https://issues.apache.org/jira/browse/TIKA-5036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18139130#comment-18139130
]
ASF GitHub Bot commented on TIKA-5036:
--------------------------------------
dschmidt commented on PR #3539:
URL: https://github.com/apache/tika/pull/3539#issuecomment-6666855531
Thanks, addressed in the last commit.
1. The detector reads the four magic bytes first and goes on only for zstd.
2. Right, it only worked by class name order. gzip blends are now recognized
in `GZipSpecializationDetector`, the way warc.gz is, and `BlenderDetector`
handles zstd only, where nothing else competes. `BlenderDetectionTest` in
tika-parsers-standard-integration-tests detects gzip and zstd blends with the
full `DefaultDetector` and with `CompositeDetector` in both orders; with the
old detectors, gzip first gives `application/gzip`.
3. `BlenderParser` now closes the decompressing stream, with the input
wrapped in `CloseShieldInputStream`.
On the zstd window at detect time: I'd rather measure before capping it, as
a small `setLongMax` could cut off real Blender files. Happy to look into it if
you want it here.
As for real files: the PR description lists what I ran it against (19 files
from Blender 2.77 to 4.2, plain, gzip and zstd, and 25 from Blender 5.x, from
public GitHub repositories); they still give the same results. None has a
license that would let it go into the repo, so the tests build their files. If
you find ASL-friendly ones in Common Crawl, I'd gladly add one.
> Blender and SketchUp: emit the embedded preview
> -----------------------------------------------
>
> Key: TIKA-5036
> URL: https://issues.apache.org/jira/browse/TIKA-5036
> Project: Tika
> Issue Type: Improvement
> Components: mime, parser
> Reporter: Dominik Schmidt
> Priority: Major
>
> {{.blend}} files carry a {{TEST}} block with an RGBA preview, {{.skp}} files
> an embedded PNG. Emitting it as THUMBNAIL gives both a preview.
> Both need media types first, see TIKA-3992. Note that {{.skp}} is registered
> as {{application/vnd.koan}} (SSEYO Koan), which SketchUp files collide with.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
