On 4/5/07, Antonio Petrelli <[EMAIL PROTECTED]> wrote:
Hi all! Besides the release process I am playing a bit with Checkstyle and its Eclipse plugin (eclipse-cs). There are some things that are configured in Struts checkstyle file that I am not convinced of: 1. The generics angular brackets must be surrounded by spaces. For me it is better to write: Map<K, V> and not Map < K, V >
I agree with you on this one. 2. The "public" redundant modifier is declared illegal in that
checkstyle file, but I think that it is not so bad.
Here I disagree. IMHO, using 'public' in interfaces demonstrates a lack of clarity. It constitutes "noise" in the interface definition that hinders rapid comprehension. When someone reads through a set of interfaces and sees 'public' scattered around, they're likely to stop and wonder if the author had some purpose to specifying 'public' that they should try to understand, when in reality the author was simply not thinking clearly enough to translate their thoughts into accurate interface definitions. We should always strive for maximum communication bandwidth, and not clutter the code with things that readers will trip over and have to stop and wonder about. -- Martin Cooper What do you think?
Ciao Antonio P.S.: I'll be on holidays, I will return on Wednesday. So if anyone wants to collect the vote, finish the release etc., has my consensus to do it :-) Happy Easter!
