[
https://issues.apache.org/jira/browse/TINKERPOP-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331719#comment-15331719
]
ASF GitHub Bot commented on TINKERPOP-1319:
-------------------------------------------
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/335#discussion_r67158389
--- Diff:
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/VertexTest.java
---
@@ -280,10 +280,9 @@ public void
shouldHaveExceptionConsistencyWhenIdNotSupportedForAddEdge() throws
}
@Test
- @FeatureRequirementSet(FeatureRequirementSet.Package.VERTICES_ONLY)
- @FeatureRequirement(featureClass = VertexPropertyFeatures.class,
feature = FEATURE_INTEGER_VALUES)
+ @FeatureRequirement(featureClass =
Graph.Features.VertexFeatures.class, feature =
Graph.Features.VertexFeatures.FEATURE_ADD_VERTICES)
public void shouldHaveStandardStringRepresentation() {
- final Vertex v = graph.addVertex("name", "marko", "age", 34);
+ final Vertex v = graph.addVertex();
--- End diff --
This might be changing the semantics of the test a little. We want to
validate that a vertex looks a certain way with `toString()`. By adding
properties, it introduces some data to the vertex object and allows the test to
validate that none of that state shows up in the `toString()`. Maybe an
off-chance of that happening I suppose. I guess the benefit is that we widen
the test footprint for providers who don't support adding properties (but
that's a really super basic thing). is there some other benefit? wdyt?
> several FeatureRequirement annotations are incorrect in gremlin-test
> --------------------------------------------------------------------
>
> Key: TINKERPOP-1319
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1319
> Project: TinkerPop
> Issue Type: Bug
> Components: test-suite
> Affects Versions: 3.2.0-incubating, 3.1.2-incubating
> Reporter: Jason Plurad
> Assignee: Jason Plurad
> Priority: Minor
> Fix For: 3.1.3, 3.2.1
>
>
> Several {{@FeatureRequirement}} annotations are incorrect in these
> {{gremlin-test}} tests
> * EdgeTest.java
> * FeatureSupportTest.java
> * GraphTest.java
> * PropertyTest.java
> * VertexPropertyTest.java
> * VertexTest.java
> I'll submit a patch for this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
