[
https://issues.apache.org/jira/browse/TINKERPOP-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331772#comment-15331772
]
ASF GitHub Bot commented on TINKERPOP-1319:
-------------------------------------------
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/335#discussion_r67163346
--- Diff:
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/FeatureSupportTest.java
---
@@ -587,7 +587,7 @@ public void
shouldSupportRemoveEdgesIfEdgeCanBeRemoved() throws Exception {
public void shouldSupportRemovePropertyIfAPropertyCanBeRemoved()
throws Exception {
try {
final Vertex v = graph.addVertex();
- final Edge e = v.addEdge("self", v);
+ final Edge e = v.addEdge("self", v, "name", "foo");
--- End diff --
In all your thinking on this PR, did you ever think of any way to "test our
tests" for proper feature assignments? perhaps that's a bit advanced and
impossible a thing to do, but anything else we could do to make this process of
adding features less error prone? or do we just need to rely on good code
reviews of tests to be sure features go in the right way?
> several FeatureRequirement annotations are incorrect in gremlin-test
> --------------------------------------------------------------------
>
> Key: TINKERPOP-1319
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1319
> Project: TinkerPop
> Issue Type: Bug
> Components: test-suite
> Affects Versions: 3.2.0-incubating, 3.1.2-incubating
> Reporter: Jason Plurad
> Assignee: Jason Plurad
> Priority: Minor
> Fix For: 3.1.3, 3.2.1
>
>
> Several {{@FeatureRequirement}} annotations are incorrect in these
> {{gremlin-test}} tests
> * EdgeTest.java
> * FeatureSupportTest.java
> * GraphTest.java
> * PropertyTest.java
> * VertexPropertyTest.java
> * VertexTest.java
> I'll submit a patch for this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
