[
https://issues.apache.org/jira/browse/TINKERPOP-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15596381#comment-15596381
]
ASF GitHub Bot commented on TINKERPOP-1507:
-------------------------------------------
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/460
TINKERPOP-1507: Pick.any and Pick.none are not in GraphSON or Gremlin-Python
https://issues.apache.org/jira/browse/TINKERPOP-1507
`Pick.any` and `Pick.none` were not in any of the registered serialization
systems -- Java or Python. Nor in the static imports. This has since been
rectified and two new test cases add to `BranchTest` and `ChooseTest` to
demonstrate that these tokens are now being processed correctly.
CHANGELOG
```
* Added `Pick.none` and `Pick.any` to the serializers and importers.
```
VOTE +1.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1507
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/460.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #460
----
commit 0fec46db21a3af0604a85b9b4bed4e47db8d1a70
Author: Marko A. Rodriguez <[email protected]>
Date: 2016-10-21T19:07:18Z
added Pick.none and Pick.any to the CoreImports. Added it to both
GraphSONModule and GryoMapper. Added two new test cases which use any and none
-- one in ChooseTest and one in BranchTest. Added none/any to GroovyTranslator
and PythonTranslator. All good in the hood.
----
> Pick.any and Pick.none are not in GraphSON or Gremlin-Python
> ------------------------------------------------------------
>
> Key: TINKERPOP-1507
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1507
> Project: TinkerPop
> Issue Type: Improvement
> Components: io, language-variant, process
> Affects Versions: 3.1.4, 3.2.2
> Reporter: Marko A. Rodriguez
> Assignee: Marko A. Rodriguez
>
> There are numerous "tokens" (enums) in Gremlin -- {{T}}, {{Order}},
> {{Compare}}, etc.
> We forgot {{Pick}}. Doh. {{Pick}} is used in branch-options to support
> "default" and "all"-type semantics in switch behavior. We need to add it to
> GraphSON and Gremlin-Python.
> More generally, I think we should consolidate all the "tokens" into a single
> Java file.
> {code}
> public class Tokens {
> public enum T { .. }
> public enum Order { .. }
> public enum VertexCardinality { ..}
> public enum Compare { .. }
> public enum Pick { .. }
> ...
> }
> {code}
> We could make it backwards compatible by:
> {code}
> T.label = Tokens.T.label.
> {code}
> By having all this consolidate, we will more easily know what we have and
> will be better able to use reflection in language variant generators.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
