[
https://issues.apache.org/jira/browse/TINKERPOP-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15604966#comment-15604966
]
ASF GitHub Bot commented on TINKERPOP-1507:
-------------------------------------------
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/460
> I will merge it to tp32 come the time and upmerge to master.
enjoy that while it lasts :)
Since you added new types for GraphSON, you should update the IO Reference
Documentation:
https://github.com/apache/tinkerpop/blob/42090f2e8445242bd662fed5fd9a0b255a5e46f9/docs/src/dev/io/graphson.asciidoc
I can't link directly to the part of the file to update, but basically, the
comments of that file contain a groovy script which generates a portion of the
graphson.asciidoc file (just cut/paste output into it). As I explain this, I
realize that perhaps this process could be nicer, but it is what it is for now.
> Pick.any and Pick.none are not in GraphSON or Gremlin-Python
> ------------------------------------------------------------
>
> Key: TINKERPOP-1507
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1507
> Project: TinkerPop
> Issue Type: Improvement
> Components: io, language-variant, process
> Affects Versions: 3.1.4, 3.2.2
> Reporter: Marko A. Rodriguez
> Assignee: Marko A. Rodriguez
>
> There are numerous "tokens" (enums) in Gremlin -- {{T}}, {{Order}},
> {{Compare}}, etc.
> We forgot {{Pick}}. Doh. {{Pick}} is used in branch-options to support
> "default" and "all"-type semantics in switch behavior. We need to add it to
> GraphSON and Gremlin-Python.
> More generally, I think we should consolidate all the "tokens" into a single
> Java file.
> {code}
> public class Tokens {
> public enum T { .. }
> public enum Order { .. }
> public enum VertexCardinality { ..}
> public enum Compare { .. }
> public enum Pick { .. }
> ...
> }
> {code}
> We could make it backwards compatible by:
> {code}
> T.label = Tokens.T.label.
> {code}
> By having all this consolidate, we will more easily know what we have and
> will be better able to use reflection in language variant generators.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
