[
https://issues.apache.org/jira/browse/TINKERPOP-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15683571#comment-15683571
]
ASF GitHub Bot commented on TINKERPOP-1548:
-------------------------------------------
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/504#discussion_r88893084
--- Diff:
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/TraversalInterruptionComputerTest.java
---
@@ -86,7 +97,7 @@ public void shouldRespectThreadInterruptionInVertexStep()
throws Exception {
// total time for test should not exceed 5 seconds - this prevents
the test from just hanging and allows
// it to finish with failure
- assertThat(startedIterating.await(5000, TimeUnit.MILLISECONDS),
CoreMatchers.is(true));
+ assertThat(startedIterating.await(1000, TimeUnit.MILLISECONDS),
CoreMatchers.is(true));
--- End diff --
Why not just leave this as 5s? Seems to work against the fix. What is the
actual timeout time value?
> Traversals can complete before interrupted in
> TraversalInterruptionComputerTest
> -------------------------------------------------------------------------------
>
> Key: TINKERPOP-1548
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1548
> Project: TinkerPop
> Issue Type: Bug
> Components: test-suite
> Affects Versions: 3.2.3
> Reporter: Ted Wilmes
> Assignee: Ted Wilmes
>
> TinkerGraphComputer {{TraversalInterruptionComputerTest}} fails for me fairly
> consistently. It appears that the test traversal is completing before
> {{t.interrupt}} on occasion which causes the test to fail because the
> {{TraversalInterruptedException}} is never thrown. I can reproduce this
> failure more consistently when running TinkerGraphComputer with 1 worker.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
