[
https://issues.apache.org/jira/browse/TINKERPOP-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15689942#comment-15689942
]
ASF GitHub Bot commented on TINKERPOP-1493:
-------------------------------------------
Github user pauljackson commented on the issue:
https://github.com/apache/tinkerpop/pull/457
Sorry, I’m fluent in git (shame). From reading, I gleaned that rebase is a
type of merge from one branch to another. Since I created the pull request on
tp31 I don’t understand what it means to rebase it on tp31. I’m happy to follow
directions if you could give me more explicit steps.
Thanks,
-Paul
From: stephen mallette [mailto:notificati...@github.com]
Sent: Saturday, November 19, 2016 7:52 AM
To: apache/tinkerpop
Cc: Paul A. Jackson; Mention
Subject: Re: [apache/tinkerpop] TINKERPOP-1493 Groovy project doesn't build
on Windows (#457)
Looks like #498<https://github.com/apache/tinkerpop/pull/498> has merged.
@pauljackson<https://github.com/pauljackson> if you could kindly rebase this on
tp31 for me I can give it a final test.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on
GitHub<https://github.com/apache/tinkerpop/pull/457#issuecomment-261712200>, or
mute the
thread<https://github.com/notifications/unsubscribe-auth/AAUcSOuRaIqzUeUX5cxZ2PqRUqWOhi8Iks5q_vDngaJpZM4KVbcO>.
________________________________
> Groovy project doesn't build on Windows
> ---------------------------------------
>
> Key: TINKERPOP-1493
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1493
> Project: TinkerPop
> Issue Type: Bug
> Components: groovy
> Affects Versions: 3.2.2
> Reporter: Paul Jackson
> Assignee: Jason Plurad
> Priority: Minor
>
> Builds on Windows fail for two reasons. First the line to create extTestDir
> is creating a path consisting of two full paths concatenated together. The
> second drive letter is seen as an illegal character:
> {code}private static final File extTestDir = new
> File(System.getProperty("user.dir"),
> TestHelper.makeTestDataDirectory(DependencyGrabberTest.class));{code}
> Second, when it comes time to delete the directory it is locked. This is
> because some instances of JarFile are created on it but not closed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
