[ 
https://issues.apache.org/jira/browse/TINKERPOP-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15689973#comment-15689973
 ] 

ASF GitHub Bot commented on TINKERPOP-1493:
-------------------------------------------

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/457
  
    well - your `tp31` is now out of date because a number of changes 
(including the one that i need to test this branch with) have been added to 
that branch that are not in yours. If you were working in our repository I 
would say that to get those changes you should rebase which will effectively 
bring in the new changes and more your commits to the head of all those changes.
    
    But it occurs to me now that you are working from a fork and perhaps you 
just need to merge `upstream/tp31` (our repo - i assume you called the remote 
"upstream") into your fork. I don't think you need to rebase your fork.


> Groovy project doesn't build on Windows
> ---------------------------------------
>
>                 Key: TINKERPOP-1493
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1493
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: groovy
>    Affects Versions: 3.2.2
>            Reporter: Paul Jackson
>            Assignee: Jason Plurad
>            Priority: Minor
>
> Builds on Windows fail for two reasons. First the line to create extTestDir 
> is creating a path consisting of two full paths concatenated together. The 
> second drive letter is seen as an illegal character:
> {code}private static final File extTestDir = new 
> File(System.getProperty("user.dir"), 
> TestHelper.makeTestDataDirectory(DependencyGrabberTest.class));{code}
> Second, when it comes time to delete the directory it is locked. This is 
> because some instances of JarFile are created on it but not closed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to