[ 
https://issues.apache.org/jira/browse/TINKERPOP-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15729590#comment-15729590
 ] 

stephen mallette commented on TINKERPOP-1582:
---------------------------------------------

i think we should aim to do this at {{tp32}}. If you just change the client 
side in gremlin-python it should not represent a breaking change in any way.  I 
still can't think of any reason why it's passing that string or why the server 
needed to support both modes. Perhaps it is just a remnant of some original 
work and now it's just unnecessary. We can remove the server side support in 
3.3.0. 

As far as the {{writeObject()}} issue I think you should just leave it as 
returning a string since a change to the return type will break the interface. 
I think you can just call {{toDict()}} as the solution. 

There's a good body of tests to validate your changes that execute as part of 
the standard build of {{mvn clean install}} (assuming you have a ".glv" file in 
your gremlin-python directory. You can read more about that here:

http://tinkerpop.apache.org/docs/current/dev/developer/#python-environment

Hopefully that gets everything fixed up - thanks for doing this.

> TraversalOpProcessor does not support custom serializers
> --------------------------------------------------------
>
>                 Key: TINKERPOP-1582
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1582
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.2.3
>            Reporter: Branden Moore
>
> The TraversalOpProcessor has its own ObjectMapper static instance, which 
> cannot be configured via the gremlin-server's YAML file.  Within the YAML 
> file, a user can configure serializers with custom IORegistries, to support 
> serialization of custom types.   However, the TraversalOpProcessor creates 
> its own ObjectMapper, for bytecode deserialization, which does not read 
> configuration information from from the YAML file.
> This prevents deserialization of custom bytecode, such as references to a 
> custom Predicate class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to