[ 
https://issues.apache.org/jira/browse/TINKERPOP-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15730836#comment-15730836
 ] 

ASF GitHub Bot commented on TINKERPOP-1582:
-------------------------------------------

GitHub user bjmoor opened a pull request:

    https://github.com/apache/tinkerpop/pull/513

    TINKERPOP-1582 - Encode Bytecode as a dict, not a string

    https://issues.apache.org/jira/browse/TINKERPOP-1582
    
    Remote connection driver was encoding the Gremlin Bytecode as a json 
string, rather than as a dict.  This caused the TraversalOpProcessor to not use 
the gremlin-server configured deserializers, but rather a non-configurable 
statically declared serializer to decode the Bytecode string.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bjmoor/tinkerpop TINKERPOP-1582

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/513.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #513
    
----
commit 0b74ea40aacaab519357626fa4c2c580ffe6b148
Author: Branden Moore <[email protected]>
Date:   2016-12-07T19:53:38Z

    [driver_remote] Encode Bytecode as a dict, not a string

----


> TraversalOpProcessor does not support custom serializers
> --------------------------------------------------------
>
>                 Key: TINKERPOP-1582
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1582
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.2.3
>            Reporter: Branden Moore
>
> The TraversalOpProcessor has its own ObjectMapper static instance, which 
> cannot be configured via the gremlin-server's YAML file.  Within the YAML 
> file, a user can configure serializers with custom IORegistries, to support 
> serialization of custom types.   However, the TraversalOpProcessor creates 
> its own ObjectMapper, for bytecode deserialization, which does not read 
> configuration information from from the YAML file.
> This prevents deserialization of custom bytecode, such as references to a 
> custom Predicate class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to