[
https://issues.apache.org/jira/browse/TINKERPOP-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890940#comment-15890940
]
ASF GitHub Bot commented on TINKERPOP-1612:
-------------------------------------------
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/565
Gremlin-Python has failed twice for me locally now. :/ I'll keep reviewing
the code aspects of Groovy.
```
[WARNING] Request for side-effect keys on
b5f1b521-1431-4ee2-892d-191d3c47a500 returned no side-effects in the cache
[WARNING] Could not find side-effects for
b5f1b521-1431-4ee2-892d-191d3c47a500.
[WARNING] Could not find side-effect key for x in
fbeaa674-19f5-4629-9f11-289ff65a2c32.
[exec] tests/driver/test_driver_remote_connection.py ......
[exec] tests/driver/test_driver_remote_connection_threaded.py ..
[exec] tests/process/test_strategies.py ..
[exec] tests/process/test_traversal.py ...
[exec] tests/structure/test_graph.py ..
[exec] tests/structure/io/test_graphson.py ...........
[exec]
[exec] generated xml file:
/Users/marko/software/tinkerpop/gremlin-python/target/python-reports/TEST-native-python.xml
[exec] =================================== FAILURES
===================================
[exec] ______________________________ test_client_async
_______________________________
[exec]
[exec] client = <gremlin_python.driver.client.Client instance at
0x10b226cf8>
[exec]
[exec] def test_client_async(client):
[exec] g = Graph().traversal()
[exec] t = g.V()
[exec] message = RequestMessage('traversal', 'bytecode',
{'gremlin': t.bytecode})
[exec] future = client.submitAsync(message)
[exec] > assert not future.done()
[exec] E assert not True
[exec] E + where True = <bound method Future.done of <Future
at 0x10b016150 state=finished returned ResultSet>>()
[exec] E + where <bound method Future.done of <Future at
0x10b016150 state=finished returned ResultSet>> = <Future at 0x10b016150
state=finished returned ResultSet>.done
[exec]
[exec] tests/driver/test_client.py:75: AssertionError
[exec] ===================== 1 failed, 35 passed in 2.71 seconds
======================
```
> Remove gremlin-groovy-test module
> ---------------------------------
>
> Key: TINKERPOP-1612
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1612
> Project: TinkerPop
> Issue Type: Improvement
> Components: test-suite
> Affects Versions: 3.2.3
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
> Labels: breaking
> Fix For: 3.3.0
>
>
> `gremlin-groovy-test` is can be for 3.3.0 with its test either migrated to
> other modules or simply removed. `gremlin-groovy` will now be tested in the
> same way that `gremlin-python` is.
> This issue is labelled as "breaking" as it removes a module that graph
> providers depend on. The tests in the module were deprecated in 3.2.4 so
> there has been some warning that this would happen. For 3.3.0, graph
> providers will want to simply remove these tests from their test suites.
> This also means a "breaking" change for those using the deprecated
> {{TinkerGraphGremlinPlugin}} in
> {{org.apache.tinkerpop.gremlin.tinkergraph.groovy.plugin}} and not the one
> introduced in 3.2.4 at {{org.apache.tinkerpop.gremlin.tinkergraph.jsr223}}.
> the same can be said of {{Neo4jGremlinPlugin}}, {{HadoopGremlinPlugin}}
> {{GiraphGremlinPlugin}} and {{SparkGremlinPlugin}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
