[
https://issues.apache.org/jira/browse/TINKERPOP-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892950#comment-15892950
]
ASF GitHub Bot commented on TINKERPOP-1612:
-------------------------------------------
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/565
This is an insane amount of work you did here. I like it. We now have put
Gremlin-Groovy and the same standing as Gremlin-Python. They are both simply
dialects (variants) of Gremlin. This is superb.
I think once this gets merged, we should take the `gremlin-tools/` work I
did in the `GraphActors` branch and put it here so we can reuse the
`TinkerGraphProvider` for Groovy, Python, etc. I think that would be a nice
cherry on top to this superb refactor.
VOTE +1.
> Remove gremlin-groovy-test module
> ---------------------------------
>
> Key: TINKERPOP-1612
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1612
> Project: TinkerPop
> Issue Type: Improvement
> Components: test-suite
> Affects Versions: 3.2.3
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
> Labels: breaking
> Fix For: 3.3.0
>
>
> `gremlin-groovy-test` is can be for 3.3.0 with its test either migrated to
> other modules or simply removed. `gremlin-groovy` will now be tested in the
> same way that `gremlin-python` is.
> This issue is labelled as "breaking" as it removes a module that graph
> providers depend on. The tests in the module were deprecated in 3.2.4 so
> there has been some warning that this would happen. For 3.3.0, graph
> providers will want to simply remove these tests from their test suites.
> This also means a "breaking" change for those using the deprecated
> {{TinkerGraphGremlinPlugin}} in
> {{org.apache.tinkerpop.gremlin.tinkergraph.groovy.plugin}} and not the one
> introduced in 3.2.4 at {{org.apache.tinkerpop.gremlin.tinkergraph.jsr223}}.
> the same can be said of {{Neo4jGremlinPlugin}}, {{HadoopGremlinPlugin}}
> {{GiraphGremlinPlugin}} and {{SparkGremlinPlugin}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
