[
https://issues.apache.org/jira/browse/TINKERPOP-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927968#comment-15927968
]
ASF GitHub Bot commented on TINKERPOP-1438:
-------------------------------------------
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/569#discussion_r106410060
--- Diff: CHANGELOG.asciidoc ---
@@ -47,6 +47,9 @@ TinkerPop 3.2.5 (Release Date: NOT OFFICIALLY RELEASED
YET)
* Improved error handling of compilation failures for very large or highly
parameterized script sent to Gremlin Server.
* Fixed a bug in `RangeByIsCountStrategy` that changed the meaning of
inner traversals.
* Improved Gremlin-Python Driver implementation by adding a threaded
client with basic connection pooling and support for pluggable websocket
clients.
+* Changed GraphManager from a final class implementation to an interface.
--- End diff --
minor formatting thing - make sure that class/interface/code names have the
backtick around them so that they format properly when the asciidoc is
generated. you might want to look at the other docs you wrote as you missed a
few instances there as well.
> Consider GraphManager as an interface
> -------------------------------------
>
> Key: TINKERPOP-1438
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1438
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.2.2
> Reporter: stephen mallette
> Priority: Minor
> Labels: breaking
>
> If {{GraphManager}} were an interface it would make embedding Gremlin Server
> easier as {{Graph}} instances could be more easily supplied by the host
> application. In doing this, It also might be good to force a
> {{TraversalSource}} to be referred to by both the {{Graph}} name and
> {{TraversalSource}} name.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
