[
https://issues.apache.org/jira/browse/TINKERPOP-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927973#comment-15927973
]
ASF GitHub Bot commented on TINKERPOP-1438:
-------------------------------------------
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/569#discussion_r106410916
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/util/ServerGremlinExecutor.java
---
@@ -100,9 +101,28 @@ public ServerGremlinExecutor(final Settings settings,
final ExecutorService grem
*/
public ServerGremlinExecutor(final Settings settings, final
ExecutorService gremlinExecutorService,
final T scheduledExecutorService, final
Class<T> scheduleExecutorServiceClass,
- final GraphManager graphManager) {
+ GraphManager graphManager) {
this.settings = settings;
+ if (null == graphManager) {
--- End diff --
looks like there's some indentation problems in the following lines of
code. should be four spaces between the curly brackets.
> Consider GraphManager as an interface
> -------------------------------------
>
> Key: TINKERPOP-1438
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1438
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.2.2
> Reporter: stephen mallette
> Priority: Minor
> Labels: breaking
>
> If {{GraphManager}} were an interface it would make embedding Gremlin Server
> easier as {{Graph}} instances could be more easily supplied by the host
> application. In doing this, It also might be good to force a
> {{TraversalSource}} to be referred to by both the {{Graph}} name and
> {{TraversalSource}} name.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
