[
https://issues.apache.org/jira/browse/TINKERPOP-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15929104#comment-15929104
]
ASF GitHub Bot commented on TINKERPOP-1652:
-------------------------------------------
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/572#discussion_r106552697
--- Diff:
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/PathRetractionStrategyTest.java
---
@@ -191,6 +206,9 @@ public void doTest() {
{__.V().as("a").optional(bothE().dedup().as("b")).
choose(select("b"), select("a","b"),
project("a").by(select("a"))),
"[[[a, b]], [[a, b]], [[a, b]], [[[a, b]]], [[a,
b]]]", null},
+
{__.V().as("a").out().program(labeledPathVertexProgram).select("a"), "[]",
null},
+
{__.V().as("a").out().program(pathVertexProgram).select("a"), "[]", null},
+
{__.V().as("a").out().program(emptyRequirementsVertexProgram).select("a"),
"[[]]", null}
--- End diff --
I don't understand how the assertions work or rather what exactly is being
tested here, but having `select('a')` as the last step, would keep the label
anyways, so that the VP would have access to it, no matter what its
requirements are, right?
> Disable PathRetractionStrategy strategy if VertexProgramStep has
> LABELLED_PATH requirement
> ------------------------------------------------------------------------------------------
>
> Key: TINKERPOP-1652
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1652
> Project: TinkerPop
> Issue Type: Bug
> Reporter: Ted Wilmes
> Assignee: Ted Wilmes
>
> [~dkuppitz] notified me that there is an issue where
> {{PathRetractionStrategy}} is incorrectly dropping path elements when a
> {{VertexProgramStep}} is present that has a {{LABELLED_PATH}} requirement.
> We already handle the case where path is required but this issue will also
> disable the strategy if a vertex program is present that requires
> {{LABELLED_PATH}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
