[ 
https://issues.apache.org/jira/browse/TINKERPOP-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15929103#comment-15929103
 ] 

ASF GitHub Bot commented on TINKERPOP-1652:
-------------------------------------------

Github user dkuppitz commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/572#discussion_r106551449
  
    --- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/PathRetractionStrategy.java
 ---
    @@ -72,7 +73,11 @@ public static PathRetractionStrategy instance() {
         public void apply(final Traversal.Admin<?, ?> traversal) {
             // do not apply this strategy if there are lambdas as you can't 
introspect to know what path information the lambdas are using
             // do not apply this strategy if a PATH requirement step is being 
used (in the future, we can do PATH requirement lookhead to be more intelligent 
about its usage)
    -        if (TraversalHelper.anyStepRecursively(step -> step instanceof 
LambdaHolder || step.getRequirements().contains(TraverserRequirement.PATH), 
TraversalHelper.getRootTraversal(traversal)))
    +        // do not apply this strategy if a VertexProgramStep is present 
with LABELLED_PATH requirements
    --- End diff --
    
    `LABELED_PATH`


> Disable PathRetractionStrategy strategy if VertexProgramStep has 
> LABELLED_PATH requirement
> ------------------------------------------------------------------------------------------
>
>                 Key: TINKERPOP-1652
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1652
>             Project: TinkerPop
>          Issue Type: Bug
>            Reporter: Ted Wilmes
>            Assignee: Ted Wilmes
>
> [~dkuppitz] notified me that there is an issue where 
> {{PathRetractionStrategy}} is incorrectly dropping path elements when a 
> {{VertexProgramStep}} is present that has a {{LABELLED_PATH}} requirement.  
> We already handle the case where path is required but this issue will also 
> disable the strategy if a vertex program is present that requires 
> {{LABELLED_PATH}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to