[
https://issues.apache.org/jira/browse/TINKERPOP-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934690#comment-15934690
]
ASF GitHub Bot commented on TINKERPOP-1625:
-------------------------------------------
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/578
TINKERPOP-1625: Improvements to has() related steps
https://issues.apache.org/jira/browse/TINKERPOP-1625
Added tests for `hasKey()` and `hasValue()`. Also tweaked up `HasTest`
which had dangling traversers not being tested. Updated docs with `hasKey()`
and `hasValue()` examples. Note that in the documentation we do not use Java
var args conventions, but instead try and keep it general to all languages.
Thus, the "technique" of `hasKey(String,String...)` is simply `hasKey(keys...)`.
VOTE +1.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1625
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/578.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #578
----
commit 2138c8e196d7b08a10510e7dffe744087e2c8e05
Author: Stephen Mallette <[email protected]>
Date: 2017-03-20T17:55:08Z
Changed benchmark for addVertex() to use the object array params
This is a the more likely way folks would add a vertex with the Graph API
so it's a better comparison. Ultimately, the speed of the benchmark didn't
change that much so that's good. CTR
commit a2fccf11e04101bf946fbfff50eb9d4ea2465853
Author: Marko A. Rodriguez <[email protected]>
Date: 2017-03-21T14:08:25Z
added hasKey() and hasValue() tests to HasTest. Removed un-tested methods
in HasTest that someone wrote, but never added respective test cases for. Added
more has()-examples to the 'Has Step' section of the documentation.
----
> Improvements to has() related steps
> -----------------------------------
>
> Key: TINKERPOP-1625
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1625
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.2.3
> Reporter: stephen mallette
>
> A number of issues related to {{has()}} prefixes steps:
> * Review {{has()}} for missing tests. {{hasKey}} for example has no tests
> * Improve documentation for {{has}} in general. The short descriptions are
> confusing and don't always make usage clear.
> ** Example: "hasKey(keys...): Remove the traverser if its property does not
> have any of the keys." - not clear that this means
> {{g.V().properties().hasKey("name")}} and not
> {{g.V().properties().hasKey("location")}}
> * Ensure consistency in the parameter names
> ** Example: {{hasKeys(keys...)}} is referenced in the docs, but in the code
> it is: {{hasKey(label, otherLabels)}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
