GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/578
TINKERPOP-1625: Improvements to has() related steps
https://issues.apache.org/jira/browse/TINKERPOP-1625
Added tests for `hasKey()` and `hasValue()`. Also tweaked up `HasTest`
which had dangling traversers not being tested. Updated docs with `hasKey()`
and `hasValue()` examples. Note that in the documentation we do not use Java
var args conventions, but instead try and keep it general to all languages.
Thus, the "technique" of `hasKey(String,String...)` is simply `hasKey(keys...)`.
VOTE +1.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1625
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/578.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #578
----
commit 2138c8e196d7b08a10510e7dffe744087e2c8e05
Author: Stephen Mallette <[email protected]>
Date: 2017-03-20T17:55:08Z
Changed benchmark for addVertex() to use the object array params
This is a the more likely way folks would add a vertex with the Graph API
so it's a better comparison. Ultimately, the speed of the benchmark didn't
change that much so that's good. CTR
commit a2fccf11e04101bf946fbfff50eb9d4ea2465853
Author: Marko A. Rodriguez <[email protected]>
Date: 2017-03-21T14:08:25Z
added hasKey() and hasValue() tests to HasTest. Removed un-tested methods
in HasTest that someone wrote, but never added respective test cases for. Added
more has()-examples to the 'Has Step' section of the documentation.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
