GitHub user FlorianHockmann opened a pull request:
https://github.com/apache/tinkerpop/pull/704
TINKERPOP-1766 Gremlin.Net: Add handling for closed connections
https://issues.apache.org/jira/browse/TINKERPOP-1766
This avoids `Connections` from being added back to the `ConnectionPool`
when they were closed which happens when the server gets unavailable. In that
case all existing `Connections` are removed from the `ConnectionPool` and
closed as they are most likely also not `Open` anymore. This is in line with
the handling for closed connections in `gremlin-driver`.
Unfortunately, I don't know of a good way to test something like this. We
probably would have to make internal classes like `Connection` public which
isn't that nice as users shouldn't see them in my opinion.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1766
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/704.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #704
----
commit 98e4e1b8201f50e1f34458a82c20f2737aa6ae53
Author: florianhockmann <[email protected]>
Date: 2017-09-02T15:54:39Z
Add handling for closed connections
Closed connections are not returned to the ConnectionPool as the client
cannot send any further requests with them. Additionally, the host is
considered to be unavailable when a connection was closed and all other
connections are closed and removed from the ConnectionPool. This is in line
with the handling for closed connection in gremlin-driver.
commit d9a4f79f7c568761461dc11d22fbf907578f7d14
Author: florianhockmann <[email protected]>
Date: 2017-09-02T16:00:52Z
Update NuGet packages of test projects
One of the dependencies (Castle.Core) produced a warning because one of its
dependencies couldn't be found in the specified version. This doesn't occur
anymore for the updated version.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
