[
https://issues.apache.org/jira/browse/TINKERPOP-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155072#comment-16155072
]
ASF GitHub Bot commented on TINKERPOP-1766:
-------------------------------------------
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/704
I've left some line comments on the pr.
Apart from the issue this patch is addressing, we should create separate
tickets for issues related to the .NET driver pool:
- Blocking (use of `lock`).
- An unbounded number of connections can be created under pressure.
- Lack of request pipelining on the same connection.
I wasn't able to focus on the .NET driver itself, my initial priority was
getting a stable `GraphTraversal` API and bytecode serialization, but we can
tackle these issues progressively in the next versions.
> Gremlin.Net: Closed connections should not be re-used
> ------------------------------------------------------
>
> Key: TINKERPOP-1766
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1766
> Project: TinkerPop
> Issue Type: Bug
> Components: language-variant
> Affects Versions: 3.3.0, 3.2.6
> Reporter: Florian Hockmann
>
> The driver of Gremlin.Net is kept very simle which holds especially true for
> the {{ConnectionPool}}. It simply returns every connection to its pool of
> usable connections that was {{disposed}} by the client. Unfortunately, this
> also applies in case the submit failed due to an already closed connection
> which means that the client will get the closed connection back from the
> {{ConnectionPool}} later and continues trying to submit messages over this
> closed connection.
> This can be fixed by checking whether the {{Connection}} is still open before
> adding it back to the {{ConnectionPool}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
