[
https://issues.apache.org/jira/browse/TINKERPOP-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166366#comment-16166366
]
ASF GitHub Bot commented on TINKERPOP-1766:
-------------------------------------------
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/704
Thanks for the explanation @spmallette. I was about to ask about the
approach for merging pull requests as the documentation only talks about the
case where separate pull requests are used for the different release branches.
(Maybe we should extend that for simpler cases where only a pull request to
tp32 is enough?)
I just tried to merge tp32 to master, but ran into a merge conflict as
apparently the changes from TINKERPOP-1744 (PR #690) are missing in master
although GitHub shows the merge commit also for the master branch:
https://github.com/apache/tinkerpop/commit/6a3fc39a912bec98707dd69d461955330627df10
Do I now have to cherry-pick them to get them into master before I merge
tp32 or what is the best approach in cases like this?
I'll close the JIRA ticket as soon as the changes are also in master.
> Gremlin.Net: Closed connections should not be re-used
> ------------------------------------------------------
>
> Key: TINKERPOP-1766
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1766
> Project: TinkerPop
> Issue Type: Bug
> Components: dotnet
> Affects Versions: 3.3.0, 3.2.6
> Reporter: Florian Hockmann
>
> The driver of Gremlin.Net is kept very simle which holds especially true for
> the {{ConnectionPool}}. It simply returns every connection to its pool of
> usable connections that was {{disposed}} by the client. Unfortunately, this
> also applies in case the submit failed due to an already closed connection
> which means that the client will get the closed connection back from the
> {{ConnectionPool}} later and continues trying to submit messages over this
> closed connection.
> This can be fixed by checking whether the {{Connection}} is still open before
> adding it back to the {{ConnectionPool}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
