ASF GitHub Bot commented on TINKERPOP-1726:

Github user robertdale commented on a diff in the pull request:

    --- Diff: CHANGELOG.asciidoc ---
    @@ -25,6 +25,7 @@ 
     * Modified `GremlinDslProcessor` so that it generated the 
`getAnonymousTraversalClass()` method to return the DSL version of `__`.
     * Added the "Kitchen Sink" test data set.
    +* Added `idleReadLimit` and `idleWriteLimit` to Gremlin Server that 
enables a "ping" and auto-close for seemingly dead clients.
    --- End diff --
    I think these should be called something more meaningful.
    idleReadLimit:  idleConnectionTimeout
    idleWriteLimit: keepAliveInterval

> Support WebSockets ping/pong keep-alive in Gremlin server
> ---------------------------------------------------------
>                 Key: TINKERPOP-1726
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1726
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.2.5
>            Reporter: Andy Davidoff
>            Priority: Major
> The ping/pong keep-alive system that is part of the WebSockets spec provides 
> for successful identification of a dropped connection from either end of the 
> connection.
> Currently, the Java client successfully issues keep-alive pings and receives 
> pong replies from the server.  Unfortunately, the server does not actively 
> ping clients, nor does it discover and react to dead clients when keep-alive 
> fails.
> This can cause pending client writes to lock up the server indefinitely when 
> a client spontaneously disconnects.

This message was sent by Atlassian JIRA

Reply via email to