[ 
https://issues.apache.org/jira/browse/TINKERPOP-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16370168#comment-16370168
 ] 

ASF GitHub Bot commented on TINKERPOP-1726:
-------------------------------------------

Github user robertdale commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/800#discussion_r169364908
  
    --- Diff: docs/src/reference/gremlin-applications.asciidoc ---
    @@ -1073,7 +1073,8 @@ The following table describes the various 
configuration options that Gremlin Ser
     |graphs |A `Map` of `Graph` configuration files where the key of the `Map` 
becomes the name to which the `Graph` will be bound and the value is the file 
name of a `Graph` configuration file. |_none_
     |gremlinPool |The number of "Gremlin" threads available to execute actual 
scripts in a `ScriptEngine`. This pool represents the workers available to 
handle blocking operations in Gremlin Server. When set to `0`, Gremlin Server 
will use the value provided by `Runtime.availableProcessors()`. |0
     |host |The name of the host to bind the server to. |localhost
    -|useEpollEventLoop |try to use epoll event loops (works only on Linux os) 
instead of netty NIO. |false
    +|idleConnectionTimeout |Time in milliseconds that the server will allow a 
channel to not receive requests from a client before it automatically closes. 
If enabled, the value provided should typically exceed the amount of time given 
to `keepAliveInterval`. Note that while this value is to be provided as 
milliseconds it will resolve to second precision. Set this value to `0` to 
disable this feature. |0
    +|keepAliveInterval |Time in milliseconds that the server will allow a 
channel to not send responses to a client before it sends a "ping" to see if it 
is still present. If it is present, the client should respond with a "pong" 
which will thus reset the `#idleConnectionTimeout` and keep the channel open. 
If enabled, this number should be smaller than the value provided to the 
`idleConnectionTimeout`. Note that while this value is to be provided as 
milliseconds it will resolve to second precision. Set this value to `0` to 
disable this feature. |0
    --- End diff --
    
    I think you want to remove the `#` on 
    ```
    `#idleConnectionTimeout`
    ```


> Support WebSockets ping/pong keep-alive in Gremlin server
> ---------------------------------------------------------
>
>                 Key: TINKERPOP-1726
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1726
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.2.5
>            Reporter: Andy Davidoff
>            Priority: Major
>
> The ping/pong keep-alive system that is part of the WebSockets spec provides 
> for successful identification of a dropped connection from either end of the 
> connection.
> Currently, the Java client successfully issues keep-alive pings and receives 
> pong replies from the server.  Unfortunately, the server does not actively 
> ping clients, nor does it discover and react to dead clients when keep-alive 
> fails.
> This can cause pending client writes to lock up the server indefinitely when 
> a client spontaneously disconnects.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to