Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/802
  
    Thanks for doing this @FlorianHockmann - i'm just dumping my brain of 
questions and thoughts on this one.
    
    So `mvn deploy` will deploy to where? dockerhub?  If so, could you include 
something in the dev docs on how you configure your system to allow for that? 
    
    i assume we would want it to deploy here: 
https://hub.docker.com/u/tinkerpop/ but i can't remember  who controls that...i 
think it's one of us......
    
    Also, what happens when we do a `mvn deploy` on a SNAPSHOT? that would be 
bad right? I think we need to prevent such things from happening somehow.
    
    what does adding this extra step do to the the overall build time (when 
building docker is enabled, of course)? I like that you made it a separate 
`<profile>` and used the `.docker` pattern we have with `.glv`. Part of this PR 
will likely need to include updates for the release process as well. 


---

Reply via email to