Github user FlorianHockmann commented on the issue:

    https://github.com/apache/tinkerpop/pull/802
  
    Thanks @spmallette, that actually looks like a good solution.
    
    I just pushed a commit that uses this solution. This not only allows 
skipping of `docker push` for SNAPSHOT versions, but I could also enable 
tagging of the minor version when the version is not SNAPSHOT, e.g., `3.2` for 
the `tp32` branch. I can also add the `latest` tag on `tp33` either with 
another PR or while merging from `tp32`. So the _To Do_ from this PR's initial 
post is now also done.
    
    To sum up what happens for the different versions:
    
    * `3.y.z-SNAPSHOT`:
      * Images are just built.
      * Tag: `3.y.z-SNAPSHOT`
    * `3.2.z`:
      * Images are built and pushed.
      * Tags: `3.2.z` and `3.2`
    * `3.3.z` (not directly part of this PR):
      * Images are built and pushed.
      * Tags: `3.3.z`, `3.3`, and `latest`
    
    I also verified the generated docs with `./docker/build.sh -d`.
    
    VOTE +1


---

Reply via email to