[
https://issues.apache.org/jira/browse/TINKERPOP-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382370#comment-16382370
]
ASF GitHub Bot commented on TINKERPOP-1897:
-------------------------------------------
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/802
> Otherwise I could also test deployment with this plugin with some test
image to a private repo and then write the dev docs.
That would be great if you could test things out in private first since
that is an option. It would be nice to know that we've worked out all the kinks
in a throwaway repo before we start putting things out in public.
> It should be enough to do docker login
that's good to know - a few words on that in the dev docs should be
sufficient so that no one has to go look it up in google.
> Now, doing a mvn deploy and therefore docker push for an image that was
already pushed shouldn't do anything when the artifacts didn't change that go
in that image.
if i understand you correctly, you're saying that if you push the image to
3.3.2-SNAPSHOT and then make changes and push again, the 3.3.2-SNAPSHOT would
update...is that right? if that is the case, then that behavior seems to match
the nature of a java "SNAPSHOT" (except that there is no archival of the older
SNAPSHOT). Either way though, I don't think we need to pollute the TinkerPop
dockerhub with SNAPSHOT deployments. I think we should look for ways to disable
the docker plugin on `deploy` if it is a SNAPSHOT version. I'm not sure that
there is a way to do that with maven directly, but I think we can come up with
a way to have the effect of not sending SNAPSHOT images to dockerhub.
> Provide Docker images of Gremlin Server and Console
> ---------------------------------------------------
>
> Key: TINKERPOP-1897
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1897
> Project: TinkerPop
> Issue Type: Improvement
> Components: console, server
> Reporter: Florian Hockmann
> Assignee: Florian Hockmann
> Priority: Major
>
> TinkerPop should provide Docker images of Gremlin Server and Gremlin Console
> that are deployed together with each release.
> This originated from the mailing list:
> [https://lists.apache.org/thread.html/744ae19afa9b2fd1984c1e11114dddc588e98786d9c21b633aab8bfa@%3Cdev.tinkerpop.apache.org%3E]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
