[ 
https://issues.apache.org/jira/browse/TINKERPOP-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16386574#comment-16386574
 ] 

ASF GitHub Bot commented on TINKERPOP-1897:
-------------------------------------------

Github user FlorianHockmann commented on the issue:

    https://github.com/apache/tinkerpop/pull/802
  
    I just verified my assumption that `docker login` should be enough to get 
deployment of Docker images working through Maven and added a short description 
of that to the dev docs.
    
    > if i understand you correctly, you're saying that if you push the image 
to 3.3.2-SNAPSHOT and then make changes and push again, the 3.3.2-SNAPSHOT 
would update...is that right? if that is the case, then that behavior seems to 
match the nature of a java "SNAPSHOT" (except that there is no archival of the 
older SNAPSHOT).
    
    Yes, exactly. Changing something about the image means that the ID will 
change and the tag will be added to the new image. So the old one won't be 
available any more through Docker Hub as it isn't tagged any more. That way, we 
only have one image per tag available and it will always be the most recent one.
    
    >  Either way though, I don't think we need to pollute the TinkerPop 
dockerhub with SNAPSHOT deployments. I think we should look for ways to disable 
the docker plugin on deploy if it is a SNAPSHOT version.
    
    I agree, I just don't know how this could be done. The plugin [contains 
`skip` 
flags](https://github.com/spotify/dockerfile-maven#skip-docker-goals-bound-to-maven-phases),
 but we have to activate them somehow for SNAPSHOT versions.


> Provide Docker images of Gremlin Server and Console
> ---------------------------------------------------
>
>                 Key: TINKERPOP-1897
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1897
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: console, server
>    Affects Versions: 3.2.7
>            Reporter: Florian Hockmann
>            Assignee: Florian Hockmann
>            Priority: Major
>
> TinkerPop should provide Docker images of Gremlin Server and Gremlin Console 
> that are deployed together with each release.
> This originated from the mailing list:
> [https://lists.apache.org/thread.html/744ae19afa9b2fd1984c1e11114dddc588e98786d9c21b633aab8bfa@%3Cdev.tinkerpop.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to