GitHub user FlorianHockmann opened a pull request:

    https://github.com/apache/tinkerpop/pull/816

    TINKERPOP-1919 Merge classes P and TraversalPredicate in Gremlin.Net

    https://issues.apache.org/jira/browse/TINKERPOP-1919
    
    This removes the `TraversalPredicate` class by including its functionality 
into `P`. That made it easier to enable our Gherkin runner to work with 
`P.And()` and `P.Or()` and having `P` as the type for step parameters is 
probably also easier to understand for users than `TraversalPredicate`.
    
    I added a `CHANGELOG` entry as this is technically a breaking change as it 
removes a public class, but I think that it's unlikely that users interacted 
directly with `TraversalPredicate` instead of only via `P.Something().And()`.
    
    This affected 4 previously ignored scenarios. Unfortunately, 2 of those are 
still ignored because of TINKERPOP-1922.
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1919

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/816.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #816
    
----
commit 97c179d29d7440ac31be791dbeb39e41e54d9a22
Author: Florian Hockmann <fh@...>
Date:   2018-03-12T20:16:18Z

     TINKERPOP-1919 Merge classes P and TraversalPredicate
    
    There is no good reason to keep those two classes separate anymore and
    having P as the type for step parameters is probably easier to
    understand for users than TraversalPredicate.

----


---

Reply via email to