[ 
https://issues.apache.org/jira/browse/TINKERPOP-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16401867#comment-16401867
 ] 

ASF GitHub Bot commented on TINKERPOP-1920:
-------------------------------------------

Github user FlorianHockmann commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/817#discussion_r175086849
  
    --- Diff: 
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/GherkinTestRunner.cs ---
    @@ -38,11 +38,7 @@ namespace Gremlin.Net.IntegrationTest.Gherkin
         public class GherkinTestRunner
         {
             private static readonly IDictionary<string, IgnoreReason> 
IgnoredScenarios =
    -            new Dictionary<string, IgnoreReason>
    -            {
    -                {"g_V_hasIdXwithinXemptyXX_count", 
IgnoreReason.PWithinWrapsArgumentsInArray},
    -                {"g_VX1X_out_aggregateXxX_out_whereXnotXwithinXaXXX", 
IgnoreReason.PWithinWrapsArgumentsInArray}
    --- End diff --
    
    Please also remove the enum value here: 
https://github.com/apache/tinkerpop/blob/tp32/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/IgnoreException.cs#L60


> Tests fail because P.Within() arguments are wrapped in an array in Gremlin.Net
> ------------------------------------------------------------------------------
>
>                 Key: TINKERPOP-1920
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1920
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: dotnet
>    Affects Versions: 3.2.7
>            Reporter: Florian Hockmann
>            Priority: Major
>             Fix For: 3.2.8, 3.3.2
>
>
> For the scenario {{g_V_hasIdXwithinXemptyXX_count}}, {{P.within([])}} will be 
> serialized as:
> {code}
> {
>     "@type": "g:P",
>     "@value": {
>         "predicate": "within",
>         "value": [
>             []
>         ]
>     }
> }
> {code}
> which fails on the server side as it tries to treat {{[]}} as an id:
>  {{Expected an id that is convertible to Integer but received class 
> java.util.ArrayList}}.
> This seems to be related to the changes made in 
> [TINKERPOP-1874|https://issues.apache.org/jira/browse/TINKERPOP-1874].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to