[ 
https://issues.apache.org/jira/browse/TINKERPOP-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404778#comment-16404778
 ] 

ASF GitHub Bot commented on TINKERPOP-1920:
-------------------------------------------

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/817
  
    @FlorianHockmann I rebased and now the tests are failing (with and without 
your suggested changes) - i assume this has something to do with the lambda 
work that just merged - any ideas?
    
    ```text
    Failures:
    1) g_V_hasIdXwithinXemptyXX_count: Failed
    Xunit.Sdk.ContainsException: Assert.Contains() Failure
    Not found: 6
    In value:  Object[] [0]
       at Xunit.Assert.Contains[T](T expected, IEnumerable`1 collection, 
IEqualityComparer`1 comparer)
       at Gremlin.Net.IntegrationTest.Gherkin.CommonSteps.AssertResult(String 
characterizedAs, DataTable table) in 
/home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/CommonSteps.cs:line
 188
    2) g_V_notXhasIdXwithinXemptyXXX_count: Failed
    Xunit.Sdk.ContainsException: Assert.Contains() Failure
    Not found: 0
    In value:  Object[] [6]
       at Xunit.Assert.Contains[T](T expected, IEnumerable`1 collection, 
IEqualityComparer`1 comparer)
       at Gremlin.Net.IntegrationTest.Gherkin.CommonSteps.AssertResult(String 
characterizedAs, DataTable table) in 
/home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/CommonSteps.cs:line
 188
    ```


> Tests fail because P.Within() arguments are wrapped in an array in Gremlin.Net
> ------------------------------------------------------------------------------
>
>                 Key: TINKERPOP-1920
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1920
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: dotnet
>    Affects Versions: 3.2.7
>            Reporter: Florian Hockmann
>            Priority: Major
>             Fix For: 3.2.8, 3.3.2
>
>
> For the scenario {{g_V_hasIdXwithinXemptyXX_count}}, {{P.within([])}} will be 
> serialized as:
> {code}
> {
>     "@type": "g:P",
>     "@value": {
>         "predicate": "within",
>         "value": [
>             []
>         ]
>     }
> }
> {code}
> which fails on the server side as it tries to treat {{[]}} as an id:
>  {{Expected an id that is convertible to Integer but received class 
> java.util.ArrayList}}.
> This seems to be related to the changes made in 
> [TINKERPOP-1874|https://issues.apache.org/jira/browse/TINKERPOP-1874].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to