[
https://issues.apache.org/jira/browse/TINKERPOP-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410152#comment-16410152
]
ASF GitHub Bot commented on TINKERPOP-1866:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/823
TINKERPOP-1866 Support g:T for .NET
https://issues.apache.org/jira/browse/TINKERPOP-1866
Issuing this PR for @FlorianHockmann now that TINKERPOP-1865 has merged.
Builds with ` mvn clean install -DskipTests && mvn verify -pl
:gremlin-dotnet-tests -DskipIntegrationTests=false`
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1866
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/823.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #823
----
commit f88cb88a8622222e3a8911e5f502af31297a41bc
Author: Florian Hockmann <fh@...>
Date: 2018-03-18T16:19:45Z
TINKERPOP-1865 Run Gremlin.Net tests with GraphSON 3.0
This required the rewrite of the GetEdges() function for the Gherkin
test runner. Additionally, 3 tests had to be ignored: 1 has the
T deserialization problem and 2 get data returned from the server that
doesn't match the expected data.
commit b9c160244d6570c457a4ae52bdab1aa80e388c4c
Author: Florian Hockmann <fh@...>
Date: 2018-03-20T14:45:11Z
TINKERPOP-1866 Add a deserializer for g:T to Gremlin.Net
----
> Support g:T for .NET
> --------------------
>
> Key: TINKERPOP-1866
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1866
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet
> Affects Versions: 3.3.1
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Critical
> Fix For: 3.3.2
>
>
> We didn't have tests for return of {{T}} which can occur with
> {{valueMap(true)}} - adding them on TINKERPOP-1860 exposed the failure in
> .NET. This may or may not be an issue for GraphSON 3.0 only. In GraphSON 2.0,
> {{g:T}} is a defined type, but it is typically not returned from the server
> outside of {{valueMap(true)}}. When that did happen in GraphSON 2.0, {{T}}
> values were simply converted to string.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
