[
https://issues.apache.org/jira/browse/TINKERPOP-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16411232#comment-16411232
]
ASF GitHub Bot commented on TINKERPOP-1866:
-------------------------------------------
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/823#discussion_r176684867
--- Diff: gremlin-dotnet/src/Gremlin.Net/Process/Traversal/EnumWrapper.cs
---
@@ -48,5 +50,32 @@ protected EnumWrapper(string enumName, string enumValue)
EnumName = enumName;
EnumValue = enumValue;
}
+
+ /// <inheritdoc />
+ public bool Equals(EnumWrapper other)
--- End diff --
Nice! we've totally missed equality checks as part of 1901.
> Support g:T for .NET
> --------------------
>
> Key: TINKERPOP-1866
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1866
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet
> Affects Versions: 3.3.1
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Critical
> Fix For: 3.3.2
>
>
> We didn't have tests for return of {{T}} which can occur with
> {{valueMap(true)}} - adding them on TINKERPOP-1860 exposed the failure in
> .NET. This may or may not be an issue for GraphSON 3.0 only. In GraphSON 2.0,
> {{g:T}} is a defined type, but it is typically not returned from the server
> outside of {{valueMap(true)}}. When that did happen in GraphSON 2.0, {{T}}
> values were simply converted to string.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
