[ 
https://issues.apache.org/jira/browse/TINKERPOP-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431033#comment-16431033
 ] 

ASF GitHub Bot commented on TINKERPOP-1927:
-------------------------------------------

GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/834

    TINKERPOP-1927 Coerced BulkSet to g:List in GraphSON 3.0

    https://issues.apache.org/jira/browse/TINKERPOP-1927
    
    Since GLVs don't have `BulkSet` infrastructure and the need to include it 
doesn't seem high the most direct fix here is to coerce to `g:List` as the 
behavior for `BulkSet` iteration is basically that same as a List.
    
    All tests pass with `docker/build.sh -t -i`
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1927

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/834.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #834
    
----
commit 2d6c28a4781786238866bbc942d7706e16ec628e
Author: Stephen Mallette <spmva@...>
Date:   2018-04-05T12:59:56Z

    TINKERPOP-1927 Coerced BulkSet to g:List in GraphSON 3.0
    
    Since GLVs don't have BulkSet infrastructure and the need to include it 
doesn't seem high the most direct fix here is to coerce to g:List as the 
behavior for BulkSet iteration is basically that same as a List.

----


> Gherkin scenario expects list with duplicates, but receives g:Set
> -----------------------------------------------------------------
>
>                 Key: TINKERPOP-1927
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1927
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: dotnet, javascript, python, test-suite
>    Affects Versions: 3.3.1
>            Reporter: Florian Hockmann
>            Assignee: stephen mallette
>            Priority: Major
>
> The scenario 
> {{g_V_storeXaX_byXoutEXcreatedX_countX_out_out_storeXaX_byXinEXcreatedX_weight_sumX}}
>  expects
> {code:java}
> | result |
> | d[1].l |
> | d[1].l |
> | d[0].l |
> | d[0].l |
> | d[0].l |
> | d[2].l |
> | d[1.0].d |
> | d[1.0].d |
> {code}
> but we receive this from the server:
> {code:java}
> {
>     "@type": "g:Set",
>     "@value": [
>         {
>             "@type": "g:Int64",
>             "@value": 1
>         },
>         {
>             "@type": "g:Int64",
>             "@value": 1
>         },
>         {
>             "@type": "g:Int64",
>             "@value": 0
>         },
>         {
>             "@type": "g:Int64",
>             "@value": 0
>         },
>         {
>             "@type": "g:Int64",
>             "@value": 0
>         },
>         {
>             "@type": "g:Int64",
>             "@value": 2
>         },
>         {
>             "@type": "g:Double",
>             "@value": 1
>         },
>         {
>             "@type": "g:Double",
>             "@value": 1
>         }
>     ]
> }
> {code}
> The set returned by the server contains 4 duplicates that shouldn't be part 
> of the expected result in the scenario.
> Unfortunately, while working on TINKERPOP-1865 we noticed that gremlin-python 
> and gremlin-javascript fail when the scenario is fixed like that. So those 
> two GLVs probably need to be fixed to handle {{g:Set}} correctly.
> After fixing the scenario, it can be removed from the list of ignored 
> scenarios in Gremlin.Net.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to