Github user spmallette commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/802#discussion_r189332152
  
    --- Diff: gremlin-console/pom.xml ---
    @@ -336,5 +336,59 @@ limitations under the License.
                     </plugins>
                 </build>
             </profile>
    +
    +        <profile>
    +            <id>docker-images</id>
    +            <activation>
    +                <activeByDefault>false</activeByDefault>
    +                <file>
    +                    <exists>.docker</exists>
    +                </file>
    +            </activation>
    +            <build>
    +                <plugins>                    
    +                    <plugin>
    +                        <groupId>com.spotify</groupId>
    +                        <artifactId>dockerfile-maven-plugin</artifactId>
    +                        <executions>
    +                            <execution>
    +                                <id>docker-image-build</id>
    +                                <goals>
    +                                    <goal>build</goal>
    +                                </goals>
    +                                <configuration>
    +                                    <tag>${project.version}</tag>
    +                                    <buildArgs>
    +                                        
<GREMLIN_CONSOLE_DIR>target/apache-tinkerpop-${project.artifactId}-${project.version}-standalone</GREMLIN_CONSOLE_DIR>
    +                                    </buildArgs>
    +                                </configuration>
    +                            </execution>
    +                            <execution>
    +                                <id>docker-image-tag-minor-version</id>
    +                                <goals>
    +                                    <goal>tag</goal>
    +                                </goals>
    +                                <configuration>                            
                         
    +                                    <tag>3.2</tag>
    --- End diff --
    
    I guess the `<tag>` must be manually updated, but perhaps that not a 
problem because it stays bound to the branch from patch version to patch 
version. Though, I do feel like that might be an easy thing to forget on minor 
version upgrades - perhaps the dev docs should have a note about that wherever 
we bump version back to SNAPSHOT. Or perhaps this could be made more dynamic 
somehow?


---

Reply via email to