Github user jorgebay commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/868#discussion_r191665300
  
    --- Diff: gremlin-dotnet/src/Gremlin.Net/Driver/Connection.cs ---
    @@ -114,11 +116,18 @@ internal class Connection : IConnection
                                 result.Add(d);
                             }
                     }
    +
    +                if (status.Code == ResponseStatusCode.Success || 
status.Code == ResponseStatusCode.NoContent)
    +                {
    +                    statusAttributes = receivedMsg.Status.Attributes;
    --- End diff --
    
    Anything we expose should be agnostic to the serialization format. Status 
attributes should not be dependent on how GraphSON3 composes the response.
    
    In this case, we are exposing a dictionary containing `@type` and `@value`, 
where `@value` is a `JArray` (a third party type).
    
    Furthermore, we should hide any third party types from our API, see 
TINKERPOP-1696 for example.


---

Reply via email to