Github user jorgebay commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/889#discussion_r201296096
  
    --- Diff: 
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/driver-remote-connection.js
 ---
    @@ -151,7 +156,16 @@ class DriverRemoteConnection extends RemoteConnection {
           return;
         }
     
    -    if (response.status.code >= 400) {
    +    if (response.status.code === 
responseStatusCode.authenticationChallenge && this._authenticator) {
    +      this._authenticator.evaluateChallenge(response).then(res => {
    +        this.submit('', 'authentication', res);
    +      }, err => {
    +        return handler.callback(err);
    +      });
    +       
    +       return;
    --- End diff --
    
    NIT: it looks like there is an extra spacing here :)


---

Reply via email to