[
https://issues.apache.org/jira/browse/TINKERPOP-2217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839796#comment-16839796
]
ASF GitHub Bot commented on TINKERPOP-2217:
-------------------------------------------
danielcweber commented on pull request #1115: Alternative approach to
TINKERPOP-2217.
URL: https://github.com/apache/tinkerpop/pull/1115
No state variable, no counter, no concurrent queue, no send-loop. Instead,
the critical section is protected by a SemaphoreSlim which allows asynchronous
waits. The up-queuing of requests is implicit through the semaphore. Besides
that, we don't fire-and-forget the send loop anymore and more (private) methods
return Task instead of void.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Race condition in Gremlin.net driver connection
> -----------------------------------------------
>
> Key: TINKERPOP-2217
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2217
> Project: TinkerPop
> Issue Type: Bug
> Components: dotnet
> Affects Versions: 3.4.1
> Reporter: Daniel C. Weber
> Priority: Critical
>
> In Connection.cs, _writeInProgress could be observed by BeginSendingMessages
> to indicate that the loop in SendMessagesFromQueueAsync is still "in flight"
> while in reality, it has already exited. While probably extremly rare, it's
> still a race condition.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)