[ 
https://issues.apache.org/jira/browse/TINKERPOP-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213870#comment-17213870
 ] 

ASF GitHub Bot commented on TINKERPOP-2432:
-------------------------------------------

spmallette commented on pull request #1341:
URL: https://github.com/apache/tinkerpop/pull/1341#issuecomment-708367515


   I needed to add in this commit as the template changed again (can't wait 
until 3.5.0 when we don't have to fuss with that system anymore and changes 
don't have to go through that) - edaa482b0e262ad054491ab51379ab4bccdc06a1
   
   other than that, this one is all settled. thanks @sergsalo for taking care 
of this one and carrying it all the way through with all the changes we 
requested. hope to see you on future contributions 🙂 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Generate correct toString() representation of bytecode in Javascript
> --------------------------------------------------------------------
>
>                 Key: TINKERPOP-2432
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2432
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: javascript
>    Affects Versions: 3.4.8
>            Reporter: Serg Salo
>            Priority: Minor
>
> I have a very simple task - generate bytecode using typescript traversal. 
> for example: 
> const g = new Graph().traversal();
> const q = g.V().hasLabel("airport").where(__.outE("route").hasId(7753));
> const query = new translator("g" as any);
> const bytecode = q.getBytecode();
> console.log(`Bytecode: ${bytecode.toString()}`);
>  
> Here is what is generated: 
>  
> Bytecode: 
> [["V"],["hasLabel","airport"],["where",\{"graph":null,"traversalStrategies":null,"bytecode":{"sourceInstructions":[],"stepInstructions":[["outE","route"],["hasId",7753]]},"traversers":null,"sideEffects":null,"_traversalStrategiesPromise":null,"_traversersIteratorIndex":0}]]
>  
> Looks like it does the first level serialization correct, but the second 
> level isn't properly serialized. 
>  
> any suggestions what is wrong with this code?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to