[
https://issues.apache.org/jira/browse/TINKERPOP-2440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217168#comment-17217168
]
ASF GitHub Bot commented on TINKERPOP-2440:
-------------------------------------------
divijvaidya commented on pull request #1343:
URL: https://github.com/apache/tinkerpop/pull/1343#issuecomment-712500482
> Good change - Glad the `shouldKeepAliveForWebSockets()` test is back. I
suppose there is nothing now testing `scheduleKeepAlive()` logic - which
remains fairly complex. I haven't thought about it, but is there any way to
continue to cover that logic with tests (until we, i assume, one day remove the
custom keep-alive all together)?
Let's keep this out of the scope of this review? Asking because we don't
even have a channelizer in the code base which would use the old code path,
hence, testing becomes difficult.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Simplify driver by delegating keepAlive logic to Netty
> ------------------------------------------------------
>
> Key: TINKERPOP-2440
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2440
> Project: TinkerPop
> Issue Type: Improvement
> Components: driver
> Affects Versions: 3.5.0, 3.4.8
> Reporter: Divij Vaidya
> Priority: Minor
>
> Java driver can be simplified by delegating the keepAlive logic to Netty's
> [IdleStateHandler|https://netty.io/4.1/api/index.html?io/netty/handler/timeout/IdleStateHandler.html]
> instead of maintaining and writing our own custom code. Note that this needs
> to be done in a backward compatible manner for 3.4.x series as the existing
> keepAlive logic should still continue to work for Channelizers other than
> WebSocketChannelizer.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
