[
https://issues.apache.org/jira/browse/TINKERPOP-2440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217796#comment-17217796
]
ASF GitHub Bot commented on TINKERPOP-2440:
-------------------------------------------
divijvaidya commented on pull request #1343:
URL: https://github.com/apache/tinkerpop/pull/1343#issuecomment-713014082
> hmm - true. perhaps some aspect of keep-alive was wrong from the
beginning. The `Connection` probably shouldn't have needed to know anything
about keep-alive infrastructure. If you agree, I think I'd propose that we
deprecate that functionality and remove it in 3.5.0 (all of this can be in a
different JIRA and we can move forward with merging this as it is). Does that
make sense?
>
> Either way, VOTE +1
Yes I agree that this should be deprecated in 3.5 I will remove it from
master as part of the merge and do a CTR update to documentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Simplify driver by delegating keepAlive logic to Netty
> ------------------------------------------------------
>
> Key: TINKERPOP-2440
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2440
> Project: TinkerPop
> Issue Type: Improvement
> Components: driver
> Affects Versions: 3.5.0, 3.4.8
> Reporter: Divij Vaidya
> Priority: Minor
>
> Java driver can be simplified by delegating the keepAlive logic to Netty's
> [IdleStateHandler|https://netty.io/4.1/api/index.html?io/netty/handler/timeout/IdleStateHandler.html]
> instead of maintaining and writing our own custom code. Note that this needs
> to be done in a backward compatible manner for 3.4.x series as the existing
> keepAlive logic should still continue to work for Channelizers other than
> WebSocketChannelizer.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
