[
https://issues.apache.org/jira/browse/TINKERPOP-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221387#comment-17221387
]
ASF GitHub Bot commented on TINKERPOP-2389:
-------------------------------------------
spmallette commented on a change in pull request #1308:
URL: https://github.com/apache/tinkerpop/pull/1308#discussion_r512655973
##########
File path:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/AbstractChannelizer.java
##########
@@ -200,6 +211,35 @@ private Authenticator createAuthenticator(final
Settings.AuthenticationSettings
}
}
+ private Authorizer createAuthorizer(final Settings.AuthorizationSettings
config) {
+ final String authorizerClass = config.authorizer;
+ if (null == authorizerClass) {
+ return null;
+ }
+ try {
+ final Class<?> clazz = Class.forName(authorizerClass);
+ final Authorizer authorizer = (Authorizer) clazz.newInstance();
+ authorizer.configure(config.config);
+ return authorizer;
+ } catch (Exception ex) {
+ logger.warn(ex.getMessage());
+ throw new IllegalStateException(String.format("Could not
create/configure Authorizer %s", authorizer), ex);
+ }
+ }
+
+ private AuthenticatorAuthorizer createAuthenticatorAuthorizer(final
Settings settings) {
+ try {
+ final Class<?> clazz =
Class.forName(settings.authentication.authenticator);
+ final AuthenticatorAuthorizer authenticatorAuthorizer =
(AuthenticatorAuthorizer) clazz.newInstance();
+ authenticatorAuthorizer.setup(settings.authentication.config);
+ authenticatorAuthorizer.configure(settings.authorization.config);
Review comment:
`setup()` for authentication and `configure()` for authorization - could
we simply unify these and go with `setup()` for both? As long as the two
methods have the same name/signature then it should look like one method from
an inheritance perspective, no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Authorization support in TinkerPop
> ----------------------------------
>
> Key: TINKERPOP-2389
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2389
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.4.7
> Reporter: Shekhar Bansal
> Priority: Major
> Attachments: Screenshot 2020-06-25 at 15.15.04.png
>
>
> Use case:
> # Tinkerpop supports multiple graphs using a single API and admin might want
> to restrict access to some of the graphs.
> # Admin might want to restrict read/write access to certain users.
>
> Proposal
> Add read/write access restrictions at graph level. We can extend it to
> executing scripts by adding execute privileges.
>
> Changes required
> Add `authorizer` block similar to `authentication` block in yaml file
>
> {code:java}
> authorization: {
> authorizer:
> org.apache.tinkerpop.gremlin.server.authorization.AllowAllAuthorizer,
> authorizationHandler:
> org.apache.tinkerpop.gremlin.server.handler.SaslAuthorizationHandler,
> config: {
> }
> }{code}
>
> Authorization will be done only if authentication is enabled. Authentication
> is done at per session basis while authorization will be done for each and
> every request.
> In `SaslAuthorizationHandler` or `HttpAuthorizationHandler` query will be
> parsed and depending on the step instructions, the query will be marked as of
> type read or write and then privilege evaluation will be done by calling
> `isAccessAllowed` method of `Authorizer`
> {code:java}
> public interface Authorizer {
> /**
> * Whether or not the authorization requires check.
> * If false will not authorzie user.
> */
> public boolean requireAuthorization();
> /**
> * Setup is called once upon system startup to initialize the {@code
> Authorizer}.
> */
> public void setup(final Map<String, Object> config);
> /**
> * A "standard" authorization implementation
> */
> public boolean isAccessAllowed(AuthorizationRequest authorizationRequest)
> throws AuthorizationException;
> }
> {code}
> Access policies can be defined in tools like `Apache Ranger`, sample policy:
> !Screenshot 2020-06-25 at 15.15.04.png|width=1017,height=548!
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
