[
https://issues.apache.org/jira/browse/TINKERPOP-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228579#comment-17228579
]
ASF GitHub Bot commented on TINKERPOP-2445:
-------------------------------------------
spmallette commented on pull request #1355:
URL: https://github.com/apache/tinkerpop/pull/1355#issuecomment-724009038
I think that the value of the speed improvement here is worth the removal
and the possible breaking change. The scope of the "break" itself seems fairly
narrow and isolated - this will not affect a lot of users (if any). If I want
to take a breaking change like this within patch versions I usually just email
the dev list with a DISCUSS thread and explain the reasoning/scope for the
breaking change (I sometimes even email the user list if i feel it is of effect
to a large number of users who might want to have an objection but i don't
think that's necessary for this change). I then end the dev list post with a
statement of a "72 hour lazy consensus in effect" and then link the DISCUSS
thread in the JIRA.
I don't think this change needs Upgrade Documentation, but a CHANGELOG entry
would be good.
Note that these initializations have already been removed on `master` iirc.
Assuming all that is in place, then VOTE +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Speed up client initialization
> ------------------------------
>
> Key: TINKERPOP-2445
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2445
> Project: TinkerPop
> Issue Type: Improvement
> Components: driver
> Affects Versions: 3.5.0, 3.4.8
> Reporter: Divij Vaidya
> Priority: Minor
> Labels: breaking
> Attachments: screenshot-1.png
>
>
> The current Java client has a lot of initialization overhead. Some of the
> things we could do to trim the fat are:
> 1. Parallelize the connection creation inside a connection pool, i.e. make
> [this for
> loop|https://github.com/apache/tinkerpop/blob/3.4-dev/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/ConnectionPool.java]
> parallel.
> 2. Do not create a bootstrap [for every
> connection|https://github.com/apache/tinkerpop/blob/3.4-dev/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Connection.java#L111].
> A single bootstrap could be reused.
> 3. Remove SASL Handler from the pipeline after negotiation is complete for a
> connection.
> 4. Do not initialize SASL Handler if not required.
> As part of this task, we should profile the start-up time and identify other
> places where we could optimize the start-up time.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
