[
https://issues.apache.org/jira/browse/TINKERPOP-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234600#comment-17234600
]
ASF GitHub Bot commented on TINKERPOP-2445:
-------------------------------------------
spmallette commented on a change in pull request #1360:
URL: https://github.com/apache/tinkerpop/pull/1360#discussion_r526072615
##########
File path:
gremlin-driver/src/test/java/org/apache/tinkerpop/gremlin/driver/ser/binary/types/sample/SamplePersonSerializerTest.java
##########
@@ -93,7 +93,7 @@ public void readValueAndWriteValueShouldBeSymmetric() throws
IOException {
writer.writeValue(person, buffer, nullable);
final SamplePerson actual = reader.readValue(buffer,
SamplePerson.class, nullable);
- assertThat(actual, new ReflectionEquals(person));
+ Assert.assertTrue(new ReflectionEquals(person).matches(actual));
Review comment:
nit: we tend to prefer to statically import the assertion method and to
avoid `assertTrue()` which provides a terrible failure message, thus we would
typically prefer: `assertThat(new ReflectionEquals(person).matches(actual),
is(true))`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Speed up client initialization
> ------------------------------
>
> Key: TINKERPOP-2445
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2445
> Project: TinkerPop
> Issue Type: Improvement
> Components: driver
> Affects Versions: 3.5.0, 3.4.8
> Reporter: Divij Vaidya
> Priority: Minor
> Labels: breaking
> Attachments: screenshot-1.png
>
>
> The current Java client has a lot of initialization overhead. Some of the
> things we could do to trim the fat are:
> 1. Parallelize the connection creation inside a connection pool, i.e. make
> [this for
> loop|https://github.com/apache/tinkerpop/blob/3.4-dev/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/ConnectionPool.java]
> parallel.
> 2. Do not create a bootstrap [for every
> connection|https://github.com/apache/tinkerpop/blob/3.4-dev/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Connection.java#L111].
> A single bootstrap could be reused.
> 3. Remove SASL Handler from the pipeline after negotiation is complete for a
> connection.
> 4. Do not initialize SASL Handler if not required.
> As part of this task, we should profile the start-up time and identify other
> places where we could optimize the start-up time.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
