[ 
https://issues.apache.org/jira/browse/TINKERPOP-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17385290#comment-17385290
 ] 

Øyvind Sæbø commented on TINKERPOP-2591:
----------------------------------------

Yes, we can pin the gremlint website to a particular version of the gremlint 
library now:)

>From my understanding ^3.5.1 will not include the alpha versions, but 
>^3.5.1-alpha1 will (see the npm semver calculator [1]). I think this would be 
>preferable compared to inserting the latest version as part of 
>bin/generate-home.sh.

If we want to display the gremlint version on the gremlint web site I suppose 
the web site could simply import the exact resolved gremlint version from the 
package-lock.json file? Exposing data from package.json or package-lock.json 
isn't exactly the best security practice, but since this is open source and 
these files are publicly available anyways I think that should be fine.

[1] https://semver.npmjs.com/

> Administrative adjustments to gremlint site
> -------------------------------------------
>
>                 Key: TINKERPOP-2591
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2591
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: gremlint
>    Affects Versions: 3.5.1
>            Reporter: Stephen Mallette
>            Priority: Minor
>
> I presume that we can now pin the gremlint web site to a particular version 
> of the gremlint library?
> https://github.com/apache/tinkerpop/blob/e1b377a98b97578017d8d815daed76e11b04c9f7/docs/gremlint/package.json#L14
> I guess we'd want the version to match the current version of the library? 
> 3.5.2-alpha1 for the case of 3.5.2-SNAPSHOT? and then when we do 
> {{bin/generate-home.sh}} we could swap that automatically to whatever the 
> most recent version is published to npm? or i guess just setting it to ^3.5.1 
> will capture the latest in npm and the local alphas?
> I think it would be good if the gremlint web site had the version displayed 
> in a footer along with the standard "Copyright © 2015-2021 The Apache 
> Software Foundation." and perhaps a link back to the 
> https?tinkerpop.apache.org site.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to