[
https://issues.apache.org/jira/browse/TINKERPOP-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424482#comment-17424482
]
ASF GitHub Bot commented on TINKERPOP-2616:
-------------------------------------------
spmallette commented on pull request #1479:
URL: https://github.com/apache/tinkerpop/pull/1479#issuecomment-934437007
@simonz-bq i've merged this - here's some additional points:
1. `master` failed on this test `shouldEnableSslAndFailIfProtocolsDontMatch`
- something is different there where we don't get an `SSLException` there but a
`ClosedChannelException`. I'm not sure why but i changed the behavior
temporarily ( e7c889967a5c40de6e4d5086e8e7d547ba6f406b ) Could you please
investigate that and see if we can get `SSLException` there so that behavior
can remain consistent?
2. now that this is merged, could you backport the change in a non-breaking
way as @divijvaidya suggested? i suppose that means, retaining the old
exception contract but pushing `SSLException` into the "cause". if you think
there is something particularly hard in doing that please let us know. we're in
the "very minor enhancements and bug fixes only" phase of 3.4-dev so if it's
anything terribly complicated perhaps we can just count it out of scope.
You can just submit whatever fix PRs are necessary on this JIRA issue. Taken
together, that should close this one out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Provide better exceptions with SSL related failures
> ---------------------------------------------------
>
> Key: TINKERPOP-2616
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2616
> Project: TinkerPop
> Issue Type: Improvement
> Components: driver
> Affects Versions: 3.4.12
> Reporter: Stephen Mallette
> Priority: Minor
> Labels: breaking
>
> Propagate SSL exception to the client. Currently, if an error occurs during
> connection setup, client observes a generic “connection failed error”. This
> is because server has no mechanism to send an exact error to the client since
> the connection was never setup. The idea is to use WebSocket error codes to
> provide a more specific error to the client.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
