[
https://issues.apache.org/jira/browse/TINKERPOP-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425004#comment-17425004
]
ASF GitHub Bot commented on TINKERPOP-2616:
-------------------------------------------
spmallette commented on pull request #1479:
URL: https://github.com/apache/tinkerpop/pull/1479#issuecomment-936282342
I've figured this out now. The JDK version did have something to do with it,
but it wasn't a JDK8 v JDK11 issue. The failure on JDK11 could be recreated on
JDK8 if you used the newest version of JDK8 (at 292). This change that disabled
TLS1.1 by default was causing the server to close the channel early producing a
different sort of exception to the client (i.e. ChannelClosedException):
https://access.redhat.com/documentation/en-us/openjdk/8/html/release_notes_for_openjdk_8.0.292/openjdk8-windows-features-and-enhancements#disabled_tls_1_0_and_1_1_versions
To fix, I modified the test to use TLS1.2 on the server and TLS1.3 on the
client and that allowed the server to configure SSL properly and allowed the
test semantics to assert an SSLException.
@simonz-bq please backport the changes of this commit
(dc051d8283ef4278940813591b4bd3dbdbe7974a ) to #1484 - as I look now I was a
bit hasty in that commit as I was just eager to see it working and pushed.
perhaps you could also:
1. add a comments to that test so that in some distant future if this test
starts failing we'll recall that "Server TLS version must be enabled by default
in the jdk for this test to work properly"
2. fix the `fail()` message in that test to mention the right versions of
TLS being used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Provide better exceptions with SSL related failures
> ---------------------------------------------------
>
> Key: TINKERPOP-2616
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2616
> Project: TinkerPop
> Issue Type: Improvement
> Components: driver
> Affects Versions: 3.4.12
> Reporter: Stephen Mallette
> Priority: Minor
> Labels: breaking
>
> Propagate SSL exception to the client. Currently, if an error occurs during
> connection setup, client observes a generic “connection failed error”. This
> is because server has no mechanism to send an exact error to the client since
> the connection was never setup. The idea is to use WebSocket error codes to
> provide a more specific error to the client.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
