[ 
https://issues.apache.org/jira/browse/TINKERPOP-2681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488933#comment-17488933
 ] 

ASF GitHub Bot commented on TINKERPOP-2681:
-------------------------------------------

mikepersonick commented on a change in pull request #1555:
URL: https://github.com/apache/tinkerpop/pull/1555#discussion_r801741000



##########
File path: 
tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/TinkerGraphWorld.java
##########
@@ -106,6 +106,7 @@ public GraphTraversalSource getGraphTraversalSource(final 
LoadGraphWith.GraphDat
 
         private static final List<String> TAGS_TO_IGNORE = Arrays.asList(
                 "@StepDrop",
+                "@StepInject",

Review comment:
       Why? Won't this cause a lot of tests (i.e. Comparability/Orderability) 
to get ignored?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


> Create merge() step to codify best practice for upsert pattern
> --------------------------------------------------------------
>
>                 Key: TINKERPOP-2681
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2681
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: language, process
>    Affects Versions: 3.5.1
>            Reporter: Dave Bechberger
>            Assignee: Stephen Mallette
>            Priority: Major
>
> Create a step that codifies the best practice for the upsert functionality 
> into a single step to make it easier to use, more discoverable, and easier 
> for implementers to optimize.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to