[
https://issues.apache.org/jira/browse/TINKERPOP-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17490915#comment-17490915
]
ASF GitHub Bot commented on TINKERPOP-2518:
-------------------------------------------
FlorianHockmann opened a new pull request #1564:
URL: https://github.com/apache/tinkerpop/pull/1564
https://issues.apache.org/jira/browse/TINKERPOP-2518
There were three categories of scenarios ignored that are now enabled:
* Some scenarios passed without any change. I don't know why they were
ignored in the first place. Maybe we've fixed something in the meantime but
forgot to enable them again.
* Some scenarios expected a decimal type as the result but the server sent a
double. I simply changed the expected type there to reflect what we get back
from the server.
* One scenario required a more complex assertion as it expects an array of
dictionaries which means that we have to perform a deep equality check.
The only kind of scenario(s) (we only have one of them on `3.5-dev`) that is
still ignores uses `null` as a key in a map which is simply not supported in
.NET. So, that's a feature that just cannot support in .NET.
I'll create a different PR for `master` as we have additional scenarios
there that are not on `3.5-dev`.
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Enhance .NET gherkin framework to deal with more advanced assertions
> --------------------------------------------------------------------
>
> Key: TINKERPOP-2518
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2518
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet
> Affects Versions: 3.5.0
> Reporter: Stephen Mallette
> Assignee: Florian Hockmann
> Priority: Major
>
> There are two pull requests which introduced some "ignores" for tests in .NET:
> https://github.com/apache/tinkerpop/pull/1383
> https://github.com/apache/tinkerpop/pull/1387
> In both cases the Gremlin seems to work fine but the assertions aren't robust
> enough in the framework to handle the results (i think). We should try to
> settle this before 3.5.0 release.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
