[
https://issues.apache.org/jira/browse/TINKERPOP-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17490922#comment-17490922
]
ASF GitHub Bot commented on TINKERPOP-2518:
-------------------------------------------
FlorianHockmann opened a new pull request #1565:
URL: https://github.com/apache/tinkerpop/pull/1565
https://issues.apache.org/jira/browse/TINKERPOP-2518
This includes the changes from #1564 which targets `3.5-dev` and adds a
commit to fix scenarios that are only on `master`.
This uncovered a bug in the `HasId step that threw a
`NullReferenceException` if the second argument was `null`. We probably have
the same problem with other steps that are just not tested yet for `null`. I
however haven't touched them here as I'm not sure yet where we actually want to
allow `null`.
Ignoring the tag `AllowNullPropertyValues` automatically in .NET simply
didn't work as we checked for the tag on the feature, but it's on the scenario.
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Enhance .NET gherkin framework to deal with more advanced assertions
> --------------------------------------------------------------------
>
> Key: TINKERPOP-2518
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2518
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet
> Affects Versions: 3.5.0
> Reporter: Stephen Mallette
> Assignee: Florian Hockmann
> Priority: Major
>
> There are two pull requests which introduced some "ignores" for tests in .NET:
> https://github.com/apache/tinkerpop/pull/1383
> https://github.com/apache/tinkerpop/pull/1387
> In both cases the Gremlin seems to work fine but the assertions aren't robust
> enough in the framework to handle the results (i think). We should try to
> settle this before 3.5.0 release.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
